Check procedure argument for NULL in RollbackToSnapshotProcedure #15503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you pls add also a test in |
krvikash
force-pushed
the
fix-npe-in-rollbackToSnapshot-procedure
branch
from
44dcd01 to
6ddaa5d
Compare
ebyhr
approved these changes
Dec 22, 2022
krvikash
added
the
no-release-notes
|
@krvikash Could you confirm other procedures as well? Follow-up PR is fine. Iceberg and Delta Lake connectors look fine at glance. Perhaps, Hive connector needs fix. |
findinpath
approved these changes
Dec 22, 2022
krvikash
force-pushed
the
fix-npe-in-rollbackToSnapshot-procedure
branch
from
6ddaa5d to
2aa05ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15399
Check procedure argument for NULL in RollbackToSnapshotProcedure to prevent NPE
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: